-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3.3 (and dependents) #158215
Ruby 3.3 (and dependents) #158215
Conversation
Can you revert this? Not everything has to be rebuilt, only things that link to ruby libraries might need a rebuilt. |
My latest push is just Ruby and its Aliases, backing out (squashed) the bumps to all the other formula. Unfortunately it looks like in doing so I may have broken a fix @crunchtime-ali added for k9s right before I pushed the squashed commit. |
This k9s break looks like merge noise, which came out of the PR when I rebased to clean it up and pick up 981c7ec. |
265093b
to
277e507
Compare
Why bump the revisions again? I really doubt that would be needed for most of the formulae in the list |
Most of the formulae that I'd initially done a blanket rebuild in the initial PR. The new bumps are more considered, and only for formulae that failed to build in CI because of the version mismatch:
|
We had a similar need in Ruby 3.2, and Ruby 3.1. I expect we also had them in prior major version bumps but I haven't tracked down all the PRs. |
I'm somewhat at a loss on these remaining failing checks. For solargraph I could explicitly declare an xz dependency, but that's purely speculative since it should work as-is. |
FWIW I also put up weechat/weechat#2055 to update Weechat's own build system to detect the new Ruby version. If they take it then this patch here should still work: we'll still need the rebuild, and the |
Explicitly declaring the xz dependency got rid of that particular failure. |
b798eff
to
da757e4
Compare
It looks like the Intel tests are reliably timing out at around 1:30. Given that the remainder seems to be passing, would it make sense to land the PR as-is, and then fix any breakage we find afterwards? Or to remove the dependents from the PR, land the newRuby, and then follow up with PRs to fix dependents? |
Thanks again @faisal, great work here! |
Update the Ruby formula to build the just-released Ruby 3.3.
depends_on "ruby"
and require an updated libruby version.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?